[PATCH] drm/amd/display: fix array index out of bound error in DCN32 DML

Rodrigo Siqueira Jordao Rodrigo.Siqueira at amd.com
Mon Dec 5 21:10:57 UTC 2022



On 12/5/22 16:08, Aurabindo Pillai wrote:
> [Why&How]
> LinkCapacitySupport array is indexed with the number of voltage states and
> not the number of max DPPs. Fix the error by changing the array
> declaration to use the correct (larger) array size of total number of
> voltage states.
> 
> Signed-off-by: Aurabindo Pillai <aurabindo.pillai at amd.com>
> ---
>   drivers/gpu/drm/amd/display/dc/dml/display_mode_vba.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dml/display_mode_vba.h b/drivers/gpu/drm/amd/display/dc/dml/display_mode_vba.h
> index d46aa4817e70..8a67f4d65d82 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml/display_mode_vba.h
> +++ b/drivers/gpu/drm/amd/display/dc/dml/display_mode_vba.h
> @@ -1162,7 +1162,7 @@ struct vba_vars_st {
>   	double UrgBurstFactorLumaPre[DC__NUM_DPP__MAX];
>   	double UrgBurstFactorChromaPre[DC__NUM_DPP__MAX];
>   	bool NotUrgentLatencyHidingPre[DC__NUM_DPP__MAX];
> -	bool LinkCapacitySupport[DC__NUM_DPP__MAX];
> +	bool LinkCapacitySupport[DC__VOLTAGE_STATES];
>   	bool VREADY_AT_OR_AFTER_VSYNC[DC__NUM_DPP__MAX];
>   	unsigned int MIN_DST_Y_NEXT_START[DC__NUM_DPP__MAX];
>   	unsigned int VFrontPorch[DC__NUM_DPP__MAX];

Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira at amd.com>


More information about the amd-gfx mailing list