[PATCH 05/18] drm/amd/display: Use mdelay to avoid crashes

Alex Deucher alexdeucher at gmail.com
Wed Dec 14 20:48:33 UTC 2022


On Wed, Dec 14, 2022 at 3:22 PM Aurabindo Pillai
<aurabindo.pillai at amd.com> wrote:
>
> From: Alex Hung <alex.hung at amd.com>
>
> [Why]
> When running IGT kms_bw test with DP monitor, some systems crash from
> msleep no matter how long or short the time is.
>
> [How]
> To replace msleep with mdelay.

Can you provide a bit more info about the crash?  A lot of platforms
don't support delay larger than 2-4ms so this change will generate
errors on ARM and possibly other platforms.

Alex

>
> Acked-by: Aurabindo Pillai <aurabindo.pillai at amd.com>
> Signed-off-by: Alex Hung <alex.hung at amd.com>
> Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira at amd.com>
> ---
>  drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> index 913a1fe6b3da..e6251ccadb70 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> @@ -1215,7 +1215,7 @@ void dce110_blank_stream(struct pipe_ctx *pipe_ctx)
>                          * After output is idle pattern some sinks need time to recognize the stream
>                          * has changed or they enter protection state and hang.
>                          */
> -                       msleep(60);
> +                       mdelay(60);
>                 } else if (pipe_ctx->stream->signal == SIGNAL_TYPE_EDP) {
>                         if (!link->dc->config.edp_no_power_sequencing) {
>                                 /*
> --
> 2.39.0
>


More information about the amd-gfx mailing list