[PATCH] drm/amdgpu: grab extra fence reference for drm_sched_job_add_dependency
Luben Tuikov
luben.tuikov at amd.com
Mon Dec 19 15:08:48 UTC 2022
Reviewed-by: Luben Tuikov <luben.tuikov at amd.com>
Regards,
Luben
On 2022-12-19 05:47, Christian König wrote:
> That function consumes the reference.
>
> Signed-off-by: Christian König <christian.koenig at amd.com>
> Fixes: aab9cf7b6954 ("drm/amdgpu: use scheduler dependencies for VM updates")
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c
> index 59cf64216fbb..535cd6569bcc 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c
> @@ -238,8 +238,10 @@ static int amdgpu_vm_sdma_update(struct amdgpu_vm_update_params *p,
> /* Wait for PD/PT moves to be completed */
> dma_resv_iter_begin(&cursor, bo->tbo.base.resv, DMA_RESV_USAGE_KERNEL);
> dma_resv_for_each_fence_unlocked(&cursor, fence) {
> + dma_fence_get(fence);
> r = drm_sched_job_add_dependency(&p->job->base, fence);
> if (r) {
> + dma_fence_put(fence);
> dma_resv_iter_end(&cursor);
> return r;
> }
More information about the amd-gfx
mailing list