[Patch v5 15/24] drm/amdkfd: CRIU implement gpu_id remapping
Yat Sin, David
David.YatSin at amd.com
Thu Feb 3 14:25:20 UTC 2022
One nit pick.
Regards,
David
@@ -673,15 +693,19 @@ static int kfd_ioctl_dbg_address_watch(struct file *filep,
memset((void *) &aw_info, 0, sizeof(struct dbg_address_watch_info));
- dev = kfd_device_by_id(args->gpu_id);
- if (!dev)
+ mutex_lock(&p->mutex);
+ pdd = kfd_process_device_data_by_id(p, args->gpu_id);
+ mutex_unlock(&p->mutex);
+ if (!pdd) {
+ pr_debug("Could not find gpu id 0x%x\n", args->gpu_id);
return -EINVAL;
+ }
+ dev = pdd->dev;
if (dev->adev->asic_type == CHIP_CARRIZO) {
pr_debug("kfd_ioctl_dbg_wave_control not supported on CZ\n");
return -EINVAL;
}
-
Unnecessary extra line
cmd_from_user = (void __user *) args->content_ptr;
/* Validate arguments */
More information about the amd-gfx
mailing list