[PATCH] drm/amdgpu: Print once if RAS unsupported
Luben Tuikov
luben.tuikov at amd.com
Thu Feb 3 22:14:21 UTC 2022
MESA polls for errors every 2-3 seconds. Printing with dev_info() causes
the dmesg log to fill up with the same message, e.g,
[18028.206676] amdgpu 0000:0b:00.0: amdgpu: df doesn't config ras function.
Make it dev_info_once(), as it isn't something correctible during boot, so
printing just once is sufficient. Also sanitize the message.
Cc: Alex Deucher <Alexander.Deucher at amd.com>
Cc: Hawking Zhang <Hawking.Zhang at amd.com>
Cc: John Clements <john.clements at amd.com>
Cc: Tao Zhou <tao.zhou1 at amd.com>
Cc: yipechai <YiPeng.Chai at amd.com>
Fixes: e93ea3d0cf434b ("drm/amdgpu: Modify gfx block to fit for the unified ras block data and ops")
Signed-off-by: Luben Tuikov <luben.tuikov at amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
index 9d7c778c1a2d8e..cddbfbb1d6447a 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
@@ -952,8 +952,8 @@ int amdgpu_ras_query_error_status(struct amdgpu_device *adev,
} else {
block_obj = amdgpu_ras_get_ras_block(adev, info->head.block, 0);
if (!block_obj || !block_obj->hw_ops) {
- dev_info(adev->dev, "%s doesn't config ras function.\n",
- get_ras_block_str(&info->head));
+ dev_info_once(adev->dev, "%s doesn't config RAS function\n",
+ get_ras_block_str(&info->head));
return -EINVAL;
}
@@ -1028,8 +1028,8 @@ int amdgpu_ras_reset_error_status(struct amdgpu_device *adev,
return -EINVAL;
if (!block_obj || !block_obj->hw_ops) {
- dev_info(adev->dev, "%s doesn't config ras function.\n",
- ras_block_str(block));
+ dev_info_once(adev->dev, "%s doesn't config RAS function\n",
+ ras_block_str(block));
return -EINVAL;
}
@@ -1066,8 +1066,8 @@ int amdgpu_ras_error_inject(struct amdgpu_device *adev,
return -EINVAL;
if (!block_obj || !block_obj->hw_ops) {
- dev_info(adev->dev, "%s doesn't config ras function.\n",
- get_ras_block_str(&info->head));
+ dev_info_once(adev->dev, "%s doesn't config RAS function\n",
+ get_ras_block_str(&info->head));
return -EINVAL;
}
@@ -1717,8 +1717,8 @@ static void amdgpu_ras_error_status_query(struct amdgpu_device *adev,
info->head.sub_block_index);
if (!block_obj || !block_obj->hw_ops) {
- dev_info(adev->dev, "%s doesn't config ras function.\n",
- get_ras_block_str(&info->head));
+ dev_info_once(adev->dev, "%s doesn't config RAS function\n",
+ get_ras_block_str(&info->head));
return;
}
base-commit: cf33ae90884f254d683436fc2538b99dc4932447
--
2.35.0.3.gb23dac905b
More information about the amd-gfx
mailing list