[PATCH 4/4] drm/amdgpu/nv: add navi GPU reset handler

Sharma, Shashank shashank.sharma at amd.com
Fri Feb 4 17:22:29 UTC 2022



On 2/4/2022 6:20 PM, Lazar, Lijo wrote:
> [AMD Official Use Only]
> 
> One more thing
> 	In suspend-reset case, won't this cause to schedule a work item on suspend? I don't know if that is a good idea, ideally we would like to clean up all work items before going to suspend.
> 
> Thanks,
> Lijo

Again, this opens scope for discussion. What if there is a GPU error 
during suspend-reset, which is very probable case.

- Shashank

> 
> -----Original Message-----
> From: Sharma, Shashank <Shashank.Sharma at amd.com>
> Sent: Friday, February 4, 2022 10:47 PM
> To: Lazar, Lijo <Lijo.Lazar at amd.com>; amd-gfx at lists.freedesktop.org
> Cc: Deucher, Alexander <Alexander.Deucher at amd.com>; Somalapuram, Amaranath <Amaranath.Somalapuram at amd.com>; Koenig, Christian <Christian.Koenig at amd.com>
> Subject: Re: [PATCH 4/4] drm/amdgpu/nv: add navi GPU reset handler
> 
> 
> 
> On 2/4/2022 6:11 PM, Lazar, Lijo wrote:
>> BTW, since this is already providing a set of values it would be useful to provide one more field as the reset reason - RAS error recovery, GPU hung recovery or something else.
> 
> Adding this additional parameter instead of blocking something in kernel, seems like a better idea. The app can filter out and read what it is interested into.
> 
> - Shashank


More information about the amd-gfx mailing list