[PATCH] drm/amd/pm: correct the sequence of sending gpu reset msg

[Huang, Ray]

[AMD Official Use Only]

Reviewed-by: Huang Rui <ray.huang at amd.com>

-----Original Message-----
From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> On Behalf Of Liu, Aaron
Sent: Monday, February 14, 2022 12:38 PM
To: Zhang, Yifan <Yifan1.Zhang at amd.com>; amd-gfx at lists.freedesktop.org
Cc: Deucher, Alexander <Alexander.Deucher at amd.com>; Zhang, Yifan <Yifan1.Zhang at amd.com>
Subject: RE: [PATCH] drm/amd/pm: correct the sequence of sending gpu reset msg

[AMD Official Use Only]

Yifan,
Please remove Change-Id.
With this fixed, Acked-by: Aaron Liu <aaron.liu at amd.com>

--
Best Regards
Aaron Liu

> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> On Behalf Of 
> Yifan Zhang
> Sent: Monday, February 14, 2022 12:12 PM
> To: amd-gfx at lists.freedesktop.org
> Cc: Deucher, Alexander <Alexander.Deucher at amd.com>; Zhang, Yifan 
> <Yifan1.Zhang at amd.com>; Liu, Aaron <Aaron.Liu at amd.com>
> Subject: [PATCH] drm/amd/pm: correct the sequence of sending gpu reset 
> msg
> 
> the 2nd parameter should be smu msg type rather than asic msg index.
> 
> Signed-off-by: Yifan Zhang <yifan1.zhang at amd.com>
> Change-Id: I0a65fac53b06c053ce193580d68cf586e77d2c2d
> ---
>  drivers/gpu/drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c
> b/drivers/gpu/drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c
> index e90387a84cbb..e2d099409123 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c
> @@ -262,14 +262,9 @@ static int yellow_carp_post_smu_init(struct 
> smu_context *smu)
> 
>  static int yellow_carp_mode_reset(struct smu_context *smu, int type)  {
> -	int ret = 0, index = 0;
> -
> -	index = smu_cmn_to_asic_specific_index(smu,
> CMN2ASIC_MAPPING_MSG,
> -				SMU_MSG_GfxDeviceDriverReset);
> -	if (index < 0)
> -		return index == -EACCES ? 0 : index;
> +	int ret = 0;
> 
> -	ret = smu_cmn_send_smc_msg_with_param(smu, (uint16_t)index,
> type, NULL);
> +	ret = smu_cmn_send_smc_msg_with_param(smu,
> +SMU_MSG_GfxDeviceDriverReset, type, NULL);
>  	if (ret)
>  		dev_err(smu->adev->dev, "Failed to mode reset!\n");
> 
> --
> 2.25.1