[PATCH v4 00/10] Overhaul `is_thunderbolt`
Lukas Wunner
lukas at wunner.de
Tue Feb 15 07:29:11 UTC 2022
On Mon, Feb 14, 2022 at 06:01:50PM -0600, Mario Limonciello wrote:
> drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 2 +-
> drivers/gpu/drm/amd/amdgpu/nbio_v2_3.c | 2 +-
> drivers/gpu/drm/nouveau/nouveau_vga.c | 4 +-
> drivers/gpu/drm/radeon/radeon_device.c | 4 +-
> drivers/gpu/drm/radeon/radeon_kms.c | 2 +-
> drivers/pci/hotplug/pciehp_hpc.c | 6 +-
> drivers/pci/pci-acpi.c | 15 ++++-
> drivers/pci/pci.c | 17 +++--
> drivers/pci/probe.c | 52 ++++++++++++++-
> drivers/pci/quirks.c | 84 +++++++++++++++++++++++++
> drivers/platform/x86/apple-gmux.c | 2 +-
> drivers/thunderbolt/nhi.h | 2 -
> include/linux/pci.h | 25 +-------
> include/linux/pci_ids.h | 3 +
> 14 files changed, 173 insertions(+), 47 deletions(-)
That's an awful lot of additional LoC for what is primarily
a refactoring job with the intent to simplify things.
Honestly this looks like an attempt to fix something that
isn't broken. Specifically, the is_thunderbolt bit apparently
can't be removed without adding new bits to struct pci_dev.
Not sure if that can be called progress.
Thanks,
Lukas
More information about the amd-gfx
mailing list