[PATCH] drm/amd/amdgpu: Add APU flag to gca_config debugfs data (v2)

[StDenis, Tom]

[AMD Official Use Only]

umr uses the config debugfs during init anyways so adding apu status here instead of fetching it out of DRM makes sense (for umr).

I'll send a v3.

Tom

________________________________________
From: Alex Deucher <alexdeucher at gmail.com>
Sent: Wednesday, February 16, 2022 09:36
To: StDenis, Tom
Cc: amd-gfx list
Subject: Re: [PATCH] drm/amd/amdgpu: Add APU flag to gca_config debugfs data (v2)

On Tue, Feb 15, 2022 at 6:47 PM Tom St Denis <tom.stdenis at amd.com> wrote:
>
> Needed by umr to detect if ip discovered ASIC is an APU or not.
>
> (v2): Remove asic type from packet it's not strictly needed
>
> Signed-off-by: Tom St Denis <tom.stdenis at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
> index 4b950de9bf66..8f0ca71862b1 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
> @@ -728,7 +728,7 @@ static ssize_t amdgpu_debugfs_gca_config_read(struct file *f, char __user *buf,
>                 return -ENOMEM;
>
>         /* version, increment each time something is added */
> -       config[no_regs++] = 3;
> +       config[no_regs++] = 4;
>         config[no_regs++] = adev->gfx.config.max_shader_engines;
>         config[no_regs++] = adev->gfx.config.max_tile_pipes;
>         config[no_regs++] = adev->gfx.config.max_cu_per_sh;
> @@ -768,6 +768,9 @@ static ssize_t amdgpu_debugfs_gca_config_read(struct file *f, char __user *buf,
>         config[no_regs++] = adev->pdev->subsystem_device;
>         config[no_regs++] = adev->pdev->subsystem_vendor;
>
> +       /* rev==4 asic_type and APU flag */

Fix the comment here. Also, we already expose the APU flag as
AMDGPU_IDS_FLAGS_FUSION via the AMDGPU_INFO_DEV_INFO query to the INFO
ioctl.  If you already use that, you should already have this.  If
not, with the comment fixed:
Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> +       config[no_regs++] = adev->flags & AMD_IS_APU ? 1 : 0;
> +
>         while (size && (*pos < no_regs * 4)) {
>                 uint32_t value;
>
> --
> 2.32.0
>