drm/amdgpu: do not enable asic reset for raven2

Limonciello, Mario mario.limonciello at amd.com
Thu Feb 17 16:18:24 UTC 2022


On 2/17/2022 03:07, Chen Gong wrote:
> The GPU reset function of raven2 is not maintained or tested, so it should be
> very unstable.
> 
> Now the amdgpu_asic_reset function is added to amdgpu_pmops_suspend, which
> causes the S3 test of raven2 to fail, so the asic_reset of raven2 is ignored
> here.
> 
> Signed-off-by: Chen Gong <curry.gong at amd.com>
I think you want a:

Fixes: 6dc8265f9803 ("drm/amdgpu: always reset the asic in suspend (v2)")

With that:
Reviewed-by: Mario Limonciello <mario.limonciello at amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/soc15.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/soc15.c b/drivers/gpu/drm/amd/amdgpu/soc15.c
> index 25e1ee2bd2f7..4c6775ff7619 100644
> --- a/drivers/gpu/drm/amd/amdgpu/soc15.c
> +++ b/drivers/gpu/drm/amd/amdgpu/soc15.c
> @@ -586,8 +586,8 @@ soc15_asic_reset_method(struct amdgpu_device *adev)
>   static int soc15_asic_reset(struct amdgpu_device *adev)
>   {
>   	/* original raven doesn't have full asic reset */
> -	if ((adev->apu_flags & AMD_APU_IS_RAVEN) &&
> -	    !(adev->apu_flags & AMD_APU_IS_RAVEN2))
> +	if ((adev->apu_flags & AMD_APU_IS_RAVEN) ||
> +	    (adev->apu_flags & AMD_APU_IS_RAVEN2))
>   		return 0;
>   
>   	switch (soc15_asic_reset_method(adev)) {



More information about the amd-gfx mailing list