[RFC PATCH v3 2/3] drm: add support modifiers for drivers whose planes only support linear layout

Esaki Tomohito etom at igel.co.jp
Mon Jan 17 05:15:48 UTC 2022

Thank you for your reviews.

On 2022/01/14 23:16, Andy Shevchenko wrote:
> On Fri, Jan 14, 2022 at 07:17:52PM +0900, Tomohito Esaki wrote:
>> The LINEAR modifier is advertised as default if a driver doesn't specify
>> modifiers.
> ...
>> +	const uint64_t default_modifiers[] = {
> + Comma?

There is no mention in the coding style about adding/removing a comma to 
the last element of an array. Is there a policy in drm driver?

I think the advantage of adding a comma to the last element of an array 
is that diff is only one line when an element is added to the end.
However since INVALID is always the last element in the modifiers array, 
I think it can be either in this case.
If there is a policy, I will match it.

Tomohito Esaki

More information about the amd-gfx mailing list