[PATCH] drm/amdgpu: remove unused variable

Christian König christian.koenig at amd.com
Wed Jan 19 07:33:55 UTC 2022


Am 19.01.22 um 07:42 schrieb mziya:
> Remove set but unused variable.
> warning: variable 'umc_reg_offset' set but not used
>
> Signed-off-by: mziya <Mohammadzafar.ziya at amd.com>

You should use your full written name here.

Apart from that nit the patch looks good to me.

Christian.

> Reported-by: kernel test robot <lkp at intel.com>
> Reviewed-by: Hawking Zhang <Hawking.Zhang at amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/umc_v8_7.c | 4 ----
>   1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/umc_v8_7.c b/drivers/gpu/drm/amd/amdgpu/umc_v8_7.c
> index 291b37f6db4e..05f79eea307c 100644
> --- a/drivers/gpu/drm/amd/amdgpu/umc_v8_7.c
> +++ b/drivers/gpu/drm/amd/amdgpu/umc_v8_7.c
> @@ -94,16 +94,12 @@ static void umc_v8_7_ecc_info_query_ras_error_count(struct amdgpu_device *adev,
>   
>   	uint32_t umc_inst        = 0;
>   	uint32_t ch_inst         = 0;
> -	uint32_t umc_reg_offset  = 0;
>   	uint32_t channel_index   = 0;
>   
>   	/* TODO: driver needs to toggle DF Cstate to ensure
>   	 * safe access of UMC registers. Will add the protection
>   	 */
>   	LOOP_UMC_INST_AND_CH(umc_inst, ch_inst) {
> -		umc_reg_offset = get_umc_v8_7_reg_offset(adev,
> -							umc_inst,
> -							ch_inst);
>   		channel_index = get_umc_v8_7_channel_index(adev,
>   							umc_inst,
>   							ch_inst);



More information about the amd-gfx mailing list