[PATCH] drm/amdgpu: Fix kernel compilation; style

Liu, Shaoyun Shaoyun.Liu at amd.com
Fri Jan 21 03:16:26 UTC 2022

[AMD Official Use Only]

Good catch .  Thanks . 
Reviewed by : shaoyun.liu <shapoyun.liu @amd.com>

-----Original Message-----
From: Tuikov, Luben <Luben.Tuikov at amd.com> 
Sent: Thursday, January 20, 2022 6:52 PM
To: amd-gfx at lists.freedesktop.org
Cc: Tuikov, Luben <Luben.Tuikov at amd.com>; Deucher, Alexander <Alexander.Deucher at amd.com>; Liu, Shaoyun <Shaoyun.Liu at amd.com>; Russell, Kent <Kent.Russell at amd.com>
Subject: [PATCH] drm/amdgpu: Fix kernel compilation; style

drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c: In function ‘is_fru_eeprom_supported’:
drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c:47:3: error: expected ‘)’ before ‘return’
   47 |   return false;
      |   ^~~~~~
drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c:46:5: note: to match this ‘(’
   46 |  if (amdgpu_sriov_vf(adev)
      |     ^

Fix kernel compilation:
	if (amdgpu_sriov_vf(adev)
		return false;
missing closing right parenthesis for the "if".

Fix style:
	/* The i2c access is blocked on VF
	 * TODO: Need other way to get the info
Has white space after the closing */.

Cc: Alex Deucher <Alexander.Deucher at amd.com>
Cc: shaoyunl <shaoyun.liu at amd.com>
Cc: Kent Russell <kent.russell at amd.com>
Fixes: 824c2051039dfc ("drm/amdgpu: Disable FRU EEPROM access for SRIOV")
Signed-off-by: Luben Tuikov <luben.tuikov at amd.com>
 drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c
index 0548e279cc9fc4..60e7e637eaa33d 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c
@@ -42,8 +42,8 @@ static bool is_fru_eeprom_supported(struct amdgpu_device *adev)
 	/* The i2c access is blocked on VF
 	 * TODO: Need other way to get the info
-	 */  
-	if (amdgpu_sriov_vf(adev)
+	 */
+	if (amdgpu_sriov_vf(adev))
 		return false;
 	/* VBIOS is of the format ###-DXXXYY-##. For SKU identification,

base-commit: 2e8e13b0a6794f3ddae0ddcd13eedb64de94f0fd

More information about the amd-gfx mailing list