[PATCH 1/2] drm/amd/pm: correct the MGpuFanBoost support for Beige Goby

Alex Deucher alexdeucher at gmail.com
Tue Jan 25 15:27:44 UTC 2022


Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

On Tue, Jan 25, 2022 at 3:57 AM Evan Quan <evan.quan at amd.com> wrote:
>
> The existing way cannot handle Beige Goby well as a different
> PPTable data structure(PPTable_beige_goby_t instead of PPTable_t)
> is used there.
>
> Signed-off-by: Evan Quan <evan.quan at amd.com>
> Change-Id: I02208c011e93c4d37769bd022e65e9084faa97e4
> ---
>  drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c
> index 651fe748e423..dcd35c68e59b 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c
> @@ -3729,14 +3729,14 @@ static ssize_t sienna_cichlid_get_ecc_info(struct smu_context *smu,
>  }
>  static int sienna_cichlid_enable_mgpu_fan_boost(struct smu_context *smu)
>  {
> -       struct smu_table_context *table_context = &smu->smu_table;
> -       PPTable_t *smc_pptable = table_context->driver_pptable;
> +       uint16_t *mgpu_fan_boost_limit_rpm;
>
> +       GET_PPTABLE_MEMBER(MGpuFanBoostLimitRpm, &mgpu_fan_boost_limit_rpm);
>         /*
>          * Skip the MGpuFanBoost setting for those ASICs
>          * which do not support it
>          */
> -       if (!smc_pptable->MGpuFanBoostLimitRpm)
> +       if (*mgpu_fan_boost_limit_rpm == 0)
>                 return 0;
>
>         return smu_cmn_send_smc_msg_with_param(smu,
> --
> 2.29.0
>


More information about the amd-gfx mailing list