[PATCH v2 01/11] lib/string_helpers: Consolidate string helpers implementation

Lucas De Marchi lucas.demarchi at intel.com
Wed Jan 26 09:39:41 UTC 2022

There are a few implementations of string helpers in the tree like yesno()
that just returns "yes" or "no" depending on a boolean argument. Those
are helpful to output strings to the user or log.

In order to consolidate them, prefix all of them str_ prefix to make it
clear what they are about and avoid symbol clashes.
Taking the commoon `val ? "yes" : "no"` implementation,  quite a few
users of open coded yesno() could later be converted to the new

$ git grep '?\s*"yes"\s*' | wc -l
$ git grep '?\s*"no"\s*' | wc -l

The inlined function should keep the const strings local to each
compilation unit, the same way it's now, thus not changing the current

Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko at gmail.com>
Acked-by: Jani Nikula <jani.nikula at intel.com>
Acked-by: Daniel Vetter <daniel.vetter at ffwll.ch>
 include/linux/string_helpers.h | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/include/linux/string_helpers.h b/include/linux/string_helpers.h
index 7a22921c9db7..4d72258d42fd 100644
--- a/include/linux/string_helpers.h
+++ b/include/linux/string_helpers.h
@@ -106,4 +106,24 @@ void kfree_strarray(char **array, size_t n);
 char **devm_kasprintf_strarray(struct device *dev, const char *prefix, size_t n);
+static inline const char *str_yes_no(bool v)
+	return v ? "yes" : "no";
+static inline const char *str_on_off(bool v)
+	return v ? "on" : "off";
+static inline const char *str_enable_disable(bool v)
+	return v ? "enable" : "disable";
+static inline const char *str_enabled_disabled(bool v)
+	return v ? "enabled" : "disabled";

More information about the amd-gfx mailing list