[PATCH] drm/amd/display: correct idle_power_optimizations disablement return value

[Quan, Evan]

[AMD Official Use Only - General]



> -----Original Message-----
> From: Alex Deucher <alexdeucher at gmail.com>
> Sent: Thursday, July 7, 2022 11:01 AM
> To: Quan, Evan <Evan.Quan at amd.com>
> Cc: amd-gfx list <amd-gfx at lists.freedesktop.org>; Deucher, Alexander
> <Alexander.Deucher at amd.com>; Pillai, Aurabindo
> <Aurabindo.Pillai at amd.com>; for 3.8 <Stable at vger.kernel.org>
> Subject: Re: [PATCH] drm/amd/display: correct idle_power_optimizations
> disablement return value
> 
> On Wed, Jul 6, 2022 at 10:46 PM Evan Quan <evan.quan at amd.com> wrote:
> >
> > [Why]
> > The return value indicates whether the operation(disable/enable)
> > succeeded or not. The existing logic reports wrong result even if the
> > disablement was performed successfully. That will make succeeding
> > reenablement abandoned as dc->idle_optimizations_allowed is always
> true.
> >
> > [How]
> > Correct the return value to reflect the real result of disablement.
> >
> > Fixes: e40fcd4a ("drm/amd/display: add DCN32/321 specific files for
> > Display Core")
> 
> Need 12 places for the git hash:
> Fixes: 235c67634230 ("drm/amd/display: add DCN32/321 specific files for
> Display Core")
> 
> > Cc: <Stable at vger.kernel.org>
> 
> This doesn't need to go to stable.  These changes are queued up for 5.20.
Thanks. Fixed in V2.

Evan
> 
> Patch is:
> Acked-by: Alex Deucher <alexander.deucher at amd.com>
> 
> > Signed-off-by: Evan Quan <evan.quan at amd.com>
> > Change-Id: If87d4cf76f6cfb36d607f051ff32f9c7870b4d6d
> > ---
> >  drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c
> > b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c
> > index d53cbfef3558..1acd74fa4e55 100644
> > --- a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c
> > +++ b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c
> > @@ -373,7 +373,7 @@ bool dcn32_apply_idle_power_optimizations(struct
> dc *dc, bool enable)
> >         dc_dmub_srv_cmd_execute(dc->ctx->dmub_srv);
> >         dc_dmub_srv_wait_idle(dc->ctx->dmub_srv);
> >
> > -       return false;
> > +       return true;
> >  }
> >
> >  /* Send DMCUB message with SubVP pipe info
> > --
> > 2.29.0
> >