[PATCH] drm/amdgpu: align between libdrm and drm api

Christian König christian.koenig at amd.com
Fri Jul 15 13:38:58 UTC 2022


Hi Ruijing,

ok in this case please prepare a kernel patch and send it to the mailing 
list with full description why we do this change.

Thanks,
Christian.

Am 15.07.22 um 15:33 schrieb Dong, Ruijing:
> [AMD Official Use Only - General]
>
> Hi Christian,
>
> You are right, when process the libdrm code review (not committed yet), we realized the corresponding file needs to align to the kernel.
> So we will need to have this header file changed first, then to process libdrm code again.
>
> Thanks,
> Ruijing
>
> -----Original Message-----
> From: Christian König <ckoenig.leichtzumerken at gmail.com>
> Sent: Friday, July 15, 2022 4:41 AM
> To: Dong, Ruijing <Ruijing.Dong at amd.com>; amd-gfx at lists.freedesktop.org
> Cc: Deucher, Alexander <Alexander.Deucher at amd.com>; Liu, Leo <Leo.Liu at amd.com>; Koenig, Christian <Christian.Koenig at amd.com>
> Subject: Re: [PATCH] drm/amdgpu: align between libdrm and drm api
>
> Am 14.07.22 um 23:22 schrieb Ruijing Dong:
>> define HW_IP_VCN_UNIFIED the same as HW_IP_VCN_ENC
> Usually that should be the other way around, libdrm aligns to the kernel.
>
> Why was that modification committed to libdrm first? There are usually plenty of warnings before we can do that.
>
> Regards,
> Christian.
>
>> Signed-off-by: Ruijing Dong <ruijing.dong at amd.com>
>> ---
>>    include/uapi/drm/amdgpu_drm.h | 1 +
>>    1 file changed, 1 insertion(+)
>>
>> diff --git a/include/uapi/drm/amdgpu_drm.h
>> b/include/uapi/drm/amdgpu_drm.h index 18d3246d636e..fe33db8441bc
>> 100644
>> --- a/include/uapi/drm/amdgpu_drm.h
>> +++ b/include/uapi/drm/amdgpu_drm.h
>> @@ -560,6 +560,7 @@ struct drm_amdgpu_gem_va {
>>    #define AMDGPU_HW_IP_UVD_ENC      5
>>    #define AMDGPU_HW_IP_VCN_DEC      6
>>    #define AMDGPU_HW_IP_VCN_ENC      7
>> +#define AMDGPU_HW_IP_VCN_UNIFIED  AMDGPU_HW_IP_VCN_ENC
>>    #define AMDGPU_HW_IP_VCN_JPEG     8
>>    #define AMDGPU_HW_IP_NUM          9
>>



More information about the amd-gfx mailing list