[PATCH v9 06/14] mm/gup: migrate device coherent pages when pinning instead of failing
Andrew Morton
akpm at linux-foundation.org
Mon Jul 18 20:32:35 UTC 2022
On Mon, 18 Jul 2022 12:56:29 +0200 David Hildenbrand <david at redhat.com> wrote:
> > /*
> > * Try to move out any movable page before pinning the range.
> > */
> > @@ -1919,7 +1948,8 @@ static long check_and_migrate_movable_pages(unsigned long nr_pages,
> > folio_nr_pages(folio));
> > }
> >
> > - if (!list_empty(&movable_page_list) || isolation_error_count)
> > + if (!list_empty(&movable_page_list) || isolation_error_count
> > + || coherent_pages)
>
> The common style is to
>
> a) add the || to the end of the previous line
> b) indent such the we have a nice-to-read alignment
>
> if (!list_empty(&movable_page_list) || isolation_error_count ||
> coherent_pages)
>
I missed that. This series is now in mm-stable so any fix will need to
be a standalone followup patch, please.
> Apart from that lgtm.
>
> Reviewed-by: David Hildenbrand <david at redhat.com>
And your reviewed-by's will be lost. Stupid git.
More information about the amd-gfx
mailing list