[PATCH 1/2] drm/amd/display: Disable dmcu fw loading for dcn314
Harry Wentland
harry.wentland at amd.com
Tue Jul 19 19:02:51 UTC 2022
On 2022-07-19 14:26, Roman.Li at amd.com wrote:
> From: Roman Li <roman.li at amd.com>
>
> [Why]
> DCN 3.1.4 uses dmub not dmcu. Attempt to identify
> dmcu firmware for dcn314 results in dm init error:
> "Unsupported ASIC type"
>
> [How]
> Add dcn314 to the list of asics that don't require dmcu
>
> Signed-off-by: Roman Li <roman.li at amd.com>
Reviewed-by: Harry Wentland <harry.wentland at amd.com>
Might be easier going forward if we simply return 0 in the
outside case statement instead of explicitly calling out
IPs that don't support DMCU. The default (any new ASIC) won't
support DMCU.
Harry
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index dae998e014b0..9fff5aa86567 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -1893,6 +1893,7 @@ static int load_dmcu_fw(struct amdgpu_device *adev)
> case IP_VERSION(3, 0, 1):
> case IP_VERSION(3, 1, 2):
> case IP_VERSION(3, 1, 3):
> + case IP_VERSION(3, 1, 4):
> case IP_VERSION(3, 1, 5):
> case IP_VERSION(3, 1, 6):
> case IP_VERSION(3, 2, 0):
More information about the amd-gfx
mailing list