[PATCH] drm/amd/pm: Add get_gfx_off_status interface

Guo, Shikai Shikai.Guo at amd.com
Mon Jul 25 03:08:58 UTC 2022


[AMD Official Use Only - General]


Thanks comment, I will change it.
-----Original Message-----
From: André Almeida <andrealmeid at igalia.com> 
Sent: Thursday, July 21, 2022 9:11 PM
To: Guo, Shikai <Shikai.Guo at amd.com>
Cc: Deucher, Alexander <Alexander.Deucher at amd.com>; amd-gfx at lists.freedesktop.org; Liang, Prike <Prike.Liang at amd.com>; Quan, Evan <Evan.Quan at amd.com>
Subject: Re: [PATCH] drm/amd/pm: Add get_gfx_off_status interface

Hi Shikai,

Could you change the commit message to

 drm/amd/pm: Add get_gfx_off_status interface for yellow carp

Otherwise, we are going to have duplicated commit messages for each new architecture supporting get_gfx_off_status.

Also, giving that this is the second version of your patch, the subject should be [PATCH v2], and the patch should contain a changelog compared to the previous patch version.

Às 05:57 de 21/07/22, shikai.guo at amd.com escreveu:
> From: Shikai Guo <Shikai.Guo at amd.com>
> 
> add get_gfx_off_status interface to yellow_carp_ppt_funcs structure.
> 
> Signed-off-by: Shikai Guo <shikai.guo at amd.com>


Thanks,
	André


More information about the amd-gfx mailing list