[PATCH 1/3] drm/amdgpu: Allow TTM to evict svm bo from same process

Felix Kuehling felix.kuehling at amd.com
Mon Jul 25 15:01:40 UTC 2022


Am 2022-07-25 um 08:23 schrieb Philip Yang:
> To support SVM range VRAM overcommitment, TTM should be able to evict
> svm bo of same process to system memory, to get space to alloc new svm
> bo.
>
> Signed-off-by: Philip Yang <Philip.Yang at amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_fence.c | 9 ++++++---
>   1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_fence.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_fence.c
> index 1d0dbff87d3f..e8bb32f4ca14 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_fence.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_fence.c
> @@ -159,11 +159,14 @@ static void amdkfd_fence_release(struct dma_fence *f)
>   }
>   
>   /**
> - * amdkfd_fence_check_mm - Check if @mm is same as that of the fence @f
> - *  if same return TRUE else return FALSE.
> + * amdkfd_fence_check_mm

I think we still need a brief description here. How about "Check whether 
to prevent eviction of @f by @mm".

With that fixed, the patch is

Reviewed-by: Felix Kuehling <Felix.Kuehling at amd.com>


>    *
>    * @f: [IN] fence
>    * @mm: [IN] mm that needs to be verified
> + *
> + * Check if @mm is same as that of the fence @f, if same return TRUE else
> + * return FALSE.
> + * For svm bo, which support vram overcommitment, always return FALSE.
>    */
>   bool amdkfd_fence_check_mm(struct dma_fence *f, struct mm_struct *mm)
>   {
> @@ -171,7 +174,7 @@ bool amdkfd_fence_check_mm(struct dma_fence *f, struct mm_struct *mm)
>   
>   	if (!fence)
>   		return false;
> -	else if (fence->mm == mm)
> +	else if (fence->mm == mm  && !fence->svm_bo)
>   		return true;
>   
>   	return false;


More information about the amd-gfx mailing list