[PATCH] drm/amd/display: Reduce stack size in the mode support function

[Rodrigo Siqueira Jordao]

On 2022-07-24 17:41, Stephen Rothwell wrote:
> Hi all,
> 
> On Fri, 22 Jul 2022 14:12:44 -0400 Alex Deucher <alexdeucher at gmail.com> wrote:
>>
>> On Fri, Jul 22, 2022 at 1:56 PM Rodrigo Siqueira <Rodrigo.Siqueira at amd.com> wrote:
>>>
>>> When we use the allmodconfig option we see the following error:
>>>
>>> drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c: In function 'dml32_ModeSupportAndSystemConfigurationFull':
>>> drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c:3799:1: error: the frame size of 2464 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]
>>>    3799 | } // ModeSupportAndSystemConfigurationFull
>>>
>>> This commit fixes this issue by moving part of the mode support
>>> operation from ModeSupportAndSystemConfigurationFull to a dedicated
>>> function.
>>>
>>> Cc: Harry Wentland <harry.wentland at amd.com>
>>> Cc: Alex Deucher <alexander.deucher at amd.com>
>>> Cc: Aurabindo Pillai <aurabindo.pillai at amd.com>
>>> Cc: Stephen Rothwell <sfr at canb.auug.org.au>
>>> Signed-off-by: Rodrigo Siqueira <Rodrigo.Siqueira at amd.com>
>>
>> Thanks for sorting this out!
>> Acked-by: Alex Deucher <alexander.deucher at amd.com>
> 
> Tested-by: Stephen Rothwell <sfr at canb.auug.org.au>
> 
> Also, after applying the above patch, the following commits are no
> longer needed:
> 
> 987949933127 drm/amd/display: reduce stack for dml32_CalculatePrefetchSchedule
> 8f08cd32b767 drm/amd/display: reduce stack for dml32_CalculateWatermarksMALLUseAndDRAMSpeedChangeSupport
> 5d526d124fe3 drm/amd/display: reduce stack for dml32_CalculateVMRowAndSwath
> f6ceebcc7825 drm/amd/display: reduce stack for dml32_CalculateSwathAndDETConfiguration
> 
> and could be reverted (or removed).

Ohhh... that's nice!

Alex, if you don't mind, I would prefer to revert the above patches to 
keep things simpler. If it is ok for you, I can prepare the revert patches.

Thanks
Siqueira