[PATCH 0/4] Revert reduce stack size for DML code

Alex Deucher alexdeucher at gmail.com
Wed Jul 27 22:22:45 UTC 2022


Series is:
Reviewed-by: Alex Deucher <alexander.deucher at amd.com>


On Wed, Jul 27, 2022 at 6:19 PM Rodrigo Siqueira
<Rodrigo.Siqueira at amd.com> wrote:
>
> We had a stack size issue on DML, and we tried to fix it by moving some
> of the local variables to some of the DML struct. In this process of
> reducing the stack size, we sent some other patches that fixed the issue
> reported by Stephen, and the below set of patches become unnecessary:
>
> 987949933127 drm/amd/display: reduce stack for dml32_CalculatePrefetchSchedule
> 8f08cd32b767 drm/amd/display: reduce stack for dml32_CalculateWatermarksMALLUseAndDRAMSpeedChangeSupport
> 5d526d124fe3 drm/amd/display: reduce stack for dml32_CalculateVMRowAndSwath
> f6ceebcc7825 drm/amd/display: reduce stack for dml32_CalculateSwathAndDETConfiguration
>
> For this reason, this patchset reverts all of the above patches.
>
> Cc: Aurabindo Pillai <aurabindo.pillai at amd.com>
> Cc: Stephen Rothwell <sfr at canb.auug.org.au>
> Cc: Alex Deucher <alexander.deucher at amd.com>
>
> Thanks
> Siqueira
>
> Rodrigo Siqueira (4):
>   Revert "drm/amd/display: reduce stack for
>     dml32_CalculatePrefetchSchedule"
>   Revert "drm/amd/display: reduce stack for
>     dml32_CalculateWatermarksMALLUseAndDRAMSpeedChangeSupport"
>   Revert "drm/amd/display: reduce stack for
>     dml32_CalculateVMRowAndSwath"
>   Revert "drm/amd/display: reduce stack for
>     dml32_CalculateSwathAndDETConfiguration"
>
>  .../dc/dml/dcn32/display_mode_vba_32.c        |  12 +-
>  .../dc/dml/dcn32/display_mode_vba_util_32.c   | 812 ++++++++++--------
>  .../dc/dml/dcn32/display_mode_vba_util_32.h   |   5 -
>  .../drm/amd/display/dc/dml/display_mode_vba.h | 106 ---
>  4 files changed, 441 insertions(+), 494 deletions(-)
>
> --
> 2.35.1
>


More information about the amd-gfx mailing list