[PATCH] drm/amdgpu: simplify amdgpu_ucode_get_load_type()

[Chen, Guchun]

Reviewed-by: Guchun Chen <guchun.chen at amd.com>

Regards,
Guchun

-----Original Message-----
From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> On Behalf Of Alex Deucher
Sent: Tuesday, June 7, 2022 2:40 AM
To: Deucher, Alexander <Alexander.Deucher at amd.com>
Cc: amd-gfx list <amd-gfx at lists.freedesktop.org>
Subject: Re: [PATCH] drm/amdgpu: simplify amdgpu_ucode_get_load_type()

Ping?

Alex

On Tue, May 24, 2022 at 10:09 PM Alex Deucher <alexander.deucher at amd.com> wrote:
>
> This is the same as the default case, so drop the extra logic.
>
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 20 --------------------
>  1 file changed, 20 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c 
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c
> index ffa4c0d207db..c312577df596 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c
> @@ -486,26 +486,6 @@ amdgpu_ucode_get_load_type(struct amdgpu_device *adev, int load_type)
>         case CHIP_POLARIS12:
>         case CHIP_VEGAM:
>                 return AMDGPU_FW_LOAD_SMU;
> -       case CHIP_VEGA10:
> -       case CHIP_RAVEN:
> -       case CHIP_VEGA12:
> -       case CHIP_VEGA20:
> -       case CHIP_ARCTURUS:
> -       case CHIP_RENOIR:
> -       case CHIP_NAVI10:
> -       case CHIP_NAVI14:
> -       case CHIP_NAVI12:
> -       case CHIP_SIENNA_CICHLID:
> -       case CHIP_NAVY_FLOUNDER:
> -       case CHIP_VANGOGH:
> -       case CHIP_DIMGREY_CAVEFISH:
> -       case CHIP_ALDEBARAN:
> -       case CHIP_BEIGE_GOBY:
> -       case CHIP_YELLOW_CARP:
> -               if (!load_type)
> -                       return AMDGPU_FW_LOAD_DIRECT;
> -               else
> -                       return AMDGPU_FW_LOAD_PSP;
>         case CHIP_CYAN_SKILLFISH:
>                 if (!(load_type &&
>                       adev->apu_flags & AMD_APU_IS_CYAN_SKILLFISH2))
> --
> 2.35.3
>