答复: [PATCH 2/5] drm/amd/pm: enable BACO on smu_v13_0_7

[Feng, Kenneth]

[AMD Official Use Only - General]


[AMD Official Use Only - General]
Yeah, synced to the latest code. Somehow ‘drm/amd/pm: drop redundant declarations’was reverted somehow at a point.
Thanks.


Best wishes
Kenneth Feng


发件人: Lazar, Lijo <Lijo.Lazar at amd.com>
日期: 星期三, 2022年6月8日 17:14
收件人: Feng, Kenneth <Kenneth.Feng at amd.com>, amd-gfx at lists.freedesktop.org <amd-gfx at lists.freedesktop.org>
主题: Re: [PATCH 2/5] drm/amd/pm: enable BACO on smu_v13_0_7


On 6/8/2022 2:35 PM, Kenneth Feng wrote:
> enable BACO on smu_v13_0_7
>
> Signed-off-by: Kenneth Feng <kenneth.feng at amd.com>
> ---
>   drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c            | 1 +
>   drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c | 7 +++++++
>   2 files changed, 8 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
> index fb04d82f66e6..f57710790b8c 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
> @@ -1456,6 +1456,7 @@ static int smu_disable_dpms(struct smu_context *smu)
>                case IP_VERSION(11, 0, 0):
>                case IP_VERSION(11, 0, 5):
>                case IP_VERSION(11, 0, 9):
> +             case IP_VERSION(13, 0, 7):
>                        return 0;
>                default:
>                        break;
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c
> index 7da42cae5d6e..dc614befcdf5 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c
> @@ -97,6 +97,7 @@ static struct cmn2asic_msg_mapping smu_v13_0_7_message_map[SMU_MSG_MAX_COUNT] =
>        MSG_MAP(UseDefaultPPTable,              PPSMC_MSG_UseDefaultPPTable,           0),
>        MSG_MAP(RunDcBtc,                       PPSMC_MSG_RunDcBtc,                    0),
>        MSG_MAP(EnterBaco,                      PPSMC_MSG_EnterBaco,                   0),
> +     MSG_MAP(ExitBaco,           PPSMC_MSG_ExitBaco,                             0),
>        MSG_MAP(SetSoftMinByFreq,               PPSMC_MSG_SetSoftMinByFreq,            1),
>        MSG_MAP(SetSoftMaxByFreq,               PPSMC_MSG_SetSoftMaxByFreq,            1),
>        MSG_MAP(SetHardMinByFreq,               PPSMC_MSG_SetHardMinByFreq,            1),
> @@ -281,6 +282,7 @@ smu_v13_0_7_get_allowed_feature_mask(struct smu_context *smu,
>        *(uint64_t *)feature_mask |= FEATURE_MASK(FEATURE_BACO_MPCLK_DS_BIT);
>        *(uint64_t *)feature_mask |= FEATURE_MASK(FEATURE_GFX_PCC_DFLL_BIT);
>        *(uint64_t *)feature_mask |= FEATURE_MASK(FEATURE_SOC_CG_BIT);
> +     *(uint64_t *)feature_mask |= FEATURE_MASK(FEATURE_BACO_BIT);
>
>        if (adev->pm.pp_feature & PP_DCEFCLK_DPM_MASK)
>                *(uint64_t *)feature_mask |= FEATURE_MASK(FEATURE_DPM_DCN_BIT);
> @@ -1584,6 +1586,11 @@ static const struct pptable_funcs smu_v13_0_7_ppt_funcs = {
>        .set_tool_table_location = smu_v13_0_set_tool_table_location,
>        .get_pp_feature_mask = smu_cmn_get_pp_feature_mask,
>        .set_pp_feature_mask = smu_cmn_set_pp_feature_mask,
> +     .baco_is_support = smu_v13_0_baco_is_support,
> +     .baco_get_state = smu_v13_0_baco_get_state,
> +     .baco_set_state = smu_v13_0_baco_set_state,
> +     .baco_enter = smu_v13_0_baco_enter,
> +     .baco_exit = smu_v13_0_baco_exit,

I remember seeing this one -  "drm/amd/pm: drop redundant declarations"
which drops smu13 baco common functions. Is this in sync with the latest
source?

Thanks,
Lijo


>   };
>
>   void smu_v13_0_7_set_ppt_funcs(struct smu_context *smu)
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20220608/ad06354d/attachment.htm>