[PATCH] drm/amdgpu/discovery: add a comment about ip_discovery firmware

Alex Deucher alexander.deucher at amd.com
Tue Mar 1 16:34:33 UTC 2022


The firmware is optional and only used as a fallback when
the IP discovery table is not available (e.g., during asic
bring up).  Once the chip goes into production, the
table will always be available on the part itself.

Unfortunately, there is no way to mark a firmware as
optional.

Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
index e4fcbb385a62..31d86d083968 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
@@ -67,6 +67,13 @@
 #include "smuio_v11_0_6.h"
 #include "smuio_v13_0.h"
 
+/* This firmware is optional, but there is no way to
+ * specify a firmware file as optional.  It is only
+ * used as a fallback when the IP discovery table
+ * is not available for some reason (e.g., during
+ * bring up).  Once the product is in production
+ * the IP discovery table is shipped on the part itself.
+ */
 #define FIRMWARE_IP_DISCOVERY "amdgpu/ip_discovery.bin"
 MODULE_FIRMWARE(FIRMWARE_IP_DISCOVERY);
 
-- 
2.35.1



More information about the amd-gfx mailing list