[PATCH] drm/amdgpu: fix a wrong ib reference
Christian König
ckoenig.leichtzumerken at gmail.com
Mon Mar 7 07:17:12 UTC 2022
Am 07.03.22 um 05:03 schrieb Lang Yu:
> It should be p->job->ibs[j] instead of p->job->ibs[i] here.
Rebase fallout, thanks for fixing!
>
> Fixes: 1027d5d791b7 (drm/amdgpu: use job and ib structures directly in CS parsers)
>
> Signed-off-by: Lang Yu <Lang.Yu at amd.com>
Reviewed-by: Christian König <christian.koenig at amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> index 662cb66493a4..e8a3078a85cc 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> @@ -783,15 +783,12 @@ static int amdgpu_cs_vm_handling(struct amdgpu_cs_parser *p)
> memcpy(ib->ptr, kptr, chunk_ib->ib_bytes);
> amdgpu_bo_kunmap(aobj);
>
> - r = amdgpu_ring_parse_cs(ring, p, p->job,
> - &p->job->ibs[i]);
> + r = amdgpu_ring_parse_cs(ring, p, p->job, ib);
> if (r)
> return r;
> } else {
> ib->ptr = (uint32_t *)kptr;
> - r = amdgpu_ring_patch_cs_in_place(ring, p,
> - p->job,
> - &p->job->ibs[i]);
> + r = amdgpu_ring_patch_cs_in_place(ring, p, p->job, ib);
> amdgpu_bo_kunmap(aobj);
> if (r)
> return r;
More information about the amd-gfx
mailing list