[PATCH 04/12] drm/amd/display: Update engine ddc

[Paul Menzel]

Dear Agustin,


Am 10.03.22 um 23:20 schrieb Agustin Gutierrez:
> From: Jing Zhou <Jing.Zhou at amd.com>
> 
> [Why]
> Crash caused by a ddc update failure

Please give more details. What setup is it? Did Linux crash or just 
print a stack trace?

Also *Update engine ddc* should be more concrete.

> [How]
> Update engine ddc before release engine.

Please add a Fixes tag.

> Reviewed-by: Wyatt Wood <Wyatt.Wood at amd.com>
> Reviewed-by: Aric Cyr <Aric.Cyr at amd.com>
> Acked-by: Agustin Gutierrez <agustin.gutierrez at amd.com>
> Signed-off-by: Jing Zhou <Jing.Zhou at amd.com>
> ---
>   drivers/gpu/drm/amd/display/dc/dce/dce_aux.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c b/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c
> index b8d6f4202413..8e814000db62 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c
> @@ -413,6 +413,7 @@ static bool acquire(
>   		return false;
>   
>   	if (!acquire_engine(engine)) {
> +		engine->ddc = ddc;
>   		release_engine(engine);
>   		return false;
>   	}


Kind regards,

Paul