[PATCH 06/12] drm/amd/display: Add new enum for EDID status

[Paul Menzel]

Dear Agustin, dear Dale,


Am 10.03.22 um 23:20 schrieb Agustin Gutierrez:
> From: Dale Zhao <dale.zhao at amd.com>
> 
> [Why]
> We must support a new type of partial edid return in the future

What changed, that you need to support it now? The exact DisplayCore(?) 
version should be documented returning this.

Anyway, please elaborate, what “partial EDID return” is exactly.

> [How]
> Add interface and case hander for partial edid

hander?

> Reviewed-by: Charlene Liu <Charlene.Liu at amd.com>
> Acked-by: Agustin Gutierrez <agustin.gutierrez at amd.com>
> Signed-off-by: Dale Zhao <dale.zhao at amd.com>
> ---
>   drivers/gpu/drm/amd/display/dc/core/dc_link.c | 3 +++
>   drivers/gpu/drm/amd/display/dc/dc_types.h     | 1 +
>   2 files changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> index b3ca3307d39d..cb87dd643180 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> @@ -1183,6 +1183,9 @@ static bool detect_link_and_local_sink(struct dc_link *link,
>   		case EDID_BAD_CHECKSUM:
>   			DC_LOG_ERROR("EDID checksum invalid.\n");
>   			break;
> +		case EDID_PARTIAL_VALID:
> +			DC_LOG_ERROR("Partial EDID valid, abandon invalid blocks.\n");

Is that an error of the monitor/display. Please add a big warning asking 
the user to contact the device manufacturer to fix it.


Kind regards,

Paul


> +			break;
>   		case EDID_NO_RESPONSE:
>   			DC_LOG_ERROR("No EDID read.\n");
>   			/*
> diff --git a/drivers/gpu/drm/amd/display/dc/dc_types.h b/drivers/gpu/drm/amd/display/dc/dc_types.h
> index 48859d5fc172..2ba9f528c0fe 100644
> --- a/drivers/gpu/drm/amd/display/dc/dc_types.h
> +++ b/drivers/gpu/drm/amd/display/dc/dc_types.h
> @@ -138,6 +138,7 @@ enum dc_edid_status {
>   	EDID_BAD_CHECKSUM,
>   	EDID_THE_SAME,
>   	EDID_FALL_BACK,
> +	EDID_PARTIAL_VALID,
>   };
>   
>   enum act_return_status {