[PATCH] drm/amd/pm: fix indenting in __smu_cmn_reg_print_error()

[Alex Deucher]

Applied.  Thanks!

Alex

On Mon, Mar 14, 2022 at 12:06 PM Luben Tuikov <luben.tuikov at amd.com> wrote:
>
> Thanks!
>
> Reviewed-by: Luben Tuikov <luben.tuikov at amd.com>
>
> Regards,
> Luben
>
> On 2022-03-14 10:04, Dan Carpenter wrote:
> > Smatch complains that the dev_err_ratelimited() is indented one tab more
> > than the surrounding lines.
> >
> >       drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu_cmn.c:174
> >       __smu_cmn_reg_print_error() warn: inconsistent indenting
> >
> > It looks like it's not a bug, just that the indenting needs to be cleaned
> > up.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
> > ---
> >  drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c | 16 ++++++++--------
> >  1 file changed, 8 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
> > index ae64d1980f10..b8d0c70ff668 100644
> > --- a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
> > +++ b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
> > @@ -164,17 +164,17 @@ static void __smu_cmn_reg_print_error(struct smu_context *smu,
> >
> >       switch (reg_c2pmsg_90) {
> >       case SMU_RESP_NONE: {
> > -     if (adev->ip_versions[MP1_HWIP][0] == IP_VERSION(13, 0, 5)) {
> > -             msg_idx = RREG32_SOC15(MP1, 0, mmMP1_C2PMSG_2);
> > -             prm     = RREG32_SOC15(MP1, 0, mmMP1_C2PMSG_34);
> > -     } else {
> > -             msg_idx = RREG32_SOC15(MP1, 0, mmMP1_SMN_C2PMSG_66);
> > -             prm     = RREG32_SOC15(MP1, 0, mmMP1_SMN_C2PMSG_82);
> > -     }
> > +             if (adev->ip_versions[MP1_HWIP][0] == IP_VERSION(13, 0, 5)) {
> > +                     msg_idx = RREG32_SOC15(MP1, 0, mmMP1_C2PMSG_2);
> > +                     prm     = RREG32_SOC15(MP1, 0, mmMP1_C2PMSG_34);
> > +             } else {
> > +                     msg_idx = RREG32_SOC15(MP1, 0, mmMP1_SMN_C2PMSG_66);
> > +                     prm     = RREG32_SOC15(MP1, 0, mmMP1_SMN_C2PMSG_82);
> > +             }
> >               dev_err_ratelimited(adev->dev,
> >                                   "SMU: I'm not done with your previous command: SMN_C2PMSG_66:0x%08X SMN_C2PMSG_82:0x%08X",
> >                                   msg_idx, prm);
> > -     }
> > +             }
> >               break;
> >       case SMU_RESP_OK:
> >               /* The SMU executed the command. It completed with a
>
> Regards,
> --
> Luben