[PATCH] drm/amdgpu: fixed the warnings reported by kernel test robot

Paul Menzel pmenzel at molgen.mpg.de
Tue Mar 15 16:17:23 UTC 2022


Dear Yi Peng,


Am 14.03.22 um 06:52 schrieb yipechai:

Please use imperative mood in the commit message summary:

 > drm/amdgpu: Fix kernel test robot warnings

But, for the reader of `git log --oneline` it’s totally unclear, what 
these warnings are, and they need to take a look at the patch. For the 
summary it does not matter, who reported it, so the better suited 
summary would have been something like below:

 > drm/amdgpu: Remove unused amdgpu_mmhub_ras_fini() and 
amdgpu_hdp_ras_fini()

> The reported warnings are as follows:
>    1.warning:no-previous-prototype-for-amdgpu_hdp_ras_fini.
>    2.warning:no-previous-prototype-for-amdgpu_mmhub_ras_fini.

Please add a space after the enumeration bullet number.

> Amdgpu_hdp_ras_fini and amdgpu_mmhub_ras_fini are unused
> in the code, they are the only functions in amdgpu_hdp.c
> and amdgpu_mmhub.c. After removing these two functions,
> both amdgpu_hdp.c and amdgpu_mmhub.c are empty, so these
> two files can be deleted to fix the warning.
> 
> Signed-off-by: yipechai <YiPeng.Chai at amd.com>

Please configure your full name.

Also the kernel test robot asks to add the tag below:

Reported-by: kernel test robot <lkp at intel.com>

Also a Fixes tag with the commit actually introducing the warning would 
have been nice.

[…]


Kind regards,

Paul


More information about the amd-gfx mailing list