[PATCH 07/13] drm/amd/display: [FW Promotion] Release 0.0.109.0

Paul Menzel pmenzel at molgen.mpg.de
Sat Mar 19 07:00:24 UTC 2022


Dear Alex, dear Anthony,


Thank you for the patch.


Am 18.03.22 um 22:47 schrieb Alex Hung:
> From: Anthony Koo <Anthony.Koo at amd.com>

Without a commit message a person not involved in AMD graphics 
development has no idea, what this version bump is useful for, and what 
“FW Promotion” is. Could you please add one, and also do it in the future?

> Reviewed-by: Aric Cyr <Aric.Cyr at amd.com>
> Acked-by: Alex Hung <alex.hung at amd.com>
> Signed-off-by: Anthony Koo <Anthony.Koo at amd.com>
> ---
>   drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h b/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h
> index 71214c7a60fc..ce773b56a778 100644
> --- a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h
> +++ b/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h
> @@ -46,10 +46,10 @@
>   
>   /* Firmware versioning. */
>   #ifdef DMUB_EXPOSE_VERSION
> -#define DMUB_FW_VERSION_GIT_HASH 0x929554ba
> +#define DMUB_FW_VERSION_GIT_HASH 0x51b95a35

Unrelated to this patch, but could you please add a comment to what git 
archive this hash refers to?

>   #define DMUB_FW_VERSION_MAJOR 0
>   #define DMUB_FW_VERSION_MINOR 0
> -#define DMUB_FW_VERSION_REVISION 108
> +#define DMUB_FW_VERSION_REVISION 109
>   #define DMUB_FW_VERSION_TEST 0
>   #define DMUB_FW_VERSION_VBIOS 0
>   #define DMUB_FW_VERSION_HOTFIX 0


Kind regards,

Paul


More information about the amd-gfx mailing list