[PATCH 10/13] drm/amd/display: remove destructive verify link for TMDS

Paul Menzel pmenzel at molgen.mpg.de
Sat Mar 19 08:40:29 UTC 2022


Dear Alex, dear Charlene,


Thank you for the patch.

Am 18.03.22 um 22:47 schrieb Alex Hung:
> From: Charlene Liu <Charlene.Liu at amd.com>
> 
> [why and how]
> TMDS not need destructive verify link

According to whom? Please document the source for that claim.

Is that just to be spec compliant, or does it cause an actual problem? 
If so, how can it be reproduced?

> Reviewed-by: Aric Cyr <Aric.Cyr at amd.com>
> Acked-by: Alan Liu <HaoPing.Liu at amd.com>
> Acked-by: Alex Hung <alex.hung at amd.com>
> Signed-off-by: Charlene Liu <Charlene.Liu at amd.com>
> ---
>   drivers/gpu/drm/amd/display/dc/core/dc_link.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> index cb87dd643180..bbaa5abdf888 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> @@ -983,8 +983,7 @@ static bool should_verify_link_capability_destructively(struct dc_link *link,
>   				destrictive = false;
>   			}
>   		}
> -	} else if (dc_is_hdmi_signal(link->local_sink->sink_signal))
> -		destrictive = true;
> +	}
>   
>   	return destrictive;
>   }

It’d be great, if you also sent a patch to fix the typo in the variable 
name.


Kind regards,

Paul


More information about the amd-gfx mailing list