[PATCH] drm/amdgpu: set noretry for gfx 10.3.7

Liang, Prike Prike.Liang at amd.com
Thu Mar 24 01:28:47 UTC 2022


[Public]

Thanks for the review. Actually, the commit here mean disable xnack on the ISA gfx1036 for KFD test, but is seems more clear to unify using IP version gfx 10.3.7 and will update the commit info.

Thanks,
Prike
> -----Original Message-----
> From: Alex Deucher <alexdeucher at gmail.com>
> Sent: Wednesday, March 23, 2022 9:21 PM
> To: Liang, Prike <Prike.Liang at amd.com>
> Cc: amd-gfx list <amd-gfx at lists.freedesktop.org>; Deucher, Alexander
> <Alexander.Deucher at amd.com>; Zhang, Yifan <Yifan1.Zhang at amd.com>;
> Huang, Ray <Ray.Huang at amd.com>
> Subject: Re: [PATCH] drm/amdgpu: set noretry for gfx 10.3.7
>
> On Wed, Mar 23, 2022 at 4:15 AM Prike Liang <Prike.Liang at amd.com> wrote:
> >
> > Disable xnack on the isa gfx10.3.6.
>
> typo: gfx10.3.6 -> gfx10.3.7
>
> With that fixed:
> Acked-by: Alex Deucher <alexander.deucher at amd.com>
>
> >
> > Signed-off-by: Prike Liang <Prike.Liang at amd.com>
> > ---
> >  drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
> > index e1635a3f2553..a66a0881a934 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
> > @@ -569,6 +569,7 @@ void amdgpu_gmc_noretry_set(struct
> amdgpu_device *adev)
> >         case IP_VERSION(10, 3, 4):
> >         case IP_VERSION(10, 3, 5):
> >         case IP_VERSION(10, 3, 6):
> > +       case IP_VERSION(10, 3, 7):
> >                 /*
> >                  * noretry = 0 will cause kfd page fault tests fail
> >                  * for some ASICs, so set default to 1 for these ASICs.
> > --
> > 2.25.1
> >


More information about the amd-gfx mailing list