[PATCH v2 2/3] drm/amdgpu: Add tlb_cb for unlocked update

Christian König christian.koenig at amd.com
Mon Mar 28 13:14:47 UTC 2022


Am 28.03.22 um 15:06 schrieb Philip Yang:
> Flush TLB needs wait for GPU update fence done. MMU notify callback to
> unmap range from GPUs uses unlocked GPU page table update, so add tlb_cb
> to unlocked update fence to increase vm->tlb_seq.
>
> Signed-off-by: Philip Yang <Philip.Yang at amd.com>

Reviewed-by: Christian König <christian.koenig at amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> index 48f326609976..683b08f756ed 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> @@ -927,7 +927,7 @@ int amdgpu_vm_bo_update_mapping(struct amdgpu_device *adev,
>   
>   	r = vm->update_funcs->commit(&params, fence);
>   
> -	if (!unlocked && (!(flags & AMDGPU_PTE_VALID) || params.table_freed)) {
> +	if (!(flags & AMDGPU_PTE_VALID) || params.table_freed) {
>   		tlb_cb->vm = vm;
>   		if (!fence || !*fence ||
>   		    dma_fence_add_callback(*fence, &tlb_cb->cb,



More information about the amd-gfx mailing list