[PATCH] drm/amdgpu/vcn: fixed no previous prototype warning.

Paul Menzel pmenzel at molgen.mpg.de
Mon May 9 11:46:32 UTC 2022


Dear James,


You sent this message 30 minutes after sending the same message before 
(Message-ID: <20220508173008.281673-1-James.Zhu at amd.com>). Are there any 
differences?

Am 08.05.22 um 20:00 schrieb James Zhu:
> Fixed warning: no previous prototype for 'vcn_dec_sw_ring_emit_fence'

Please use imperative mood in the commit message summary. Maybe even:

 > Include header for `vcn_dec_sw_ring_emit_fence()`

Also, please do not add a dot/period to the end of commit messages.


Kind regards,

Paul


> Signed-off-by: James Zhu <James.Zhu at amd.com>
> Reported-by: kernel test robot <lkp at intel.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/vcn_sw_ring.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_sw_ring.c b/drivers/gpu/drm/amd/amdgpu/vcn_sw_ring.c
> index f4f97f0f5c64..1ceda3d0cd5b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/vcn_sw_ring.c
> +++ b/drivers/gpu/drm/amd/amdgpu/vcn_sw_ring.c
> @@ -22,6 +22,7 @@
>    */
>   
>   #include "amdgpu.h"
> +#include "vcn_sw_ring.h"
>   
>   void vcn_dec_sw_ring_emit_fence(struct amdgpu_ring *ring, u64 addr,
>   	u64 seq, uint32_t flags)


More information about the amd-gfx mailing list