How are the DC patches tested?

[Wheeler, Daniel]

[Public]

Hi Paul,

I've made some edits to my cover letter to hopefully make it clearer with what is being done.




		Hi all,
 
		This week this patchset was tested on the following systems:
 
		HP Envy 360, with Ryzen 5 4500U
		Lenovo Thinkpad T14s Gen2, with AMD Ryzen 5 5650U 
		Sapphire Pulse RX5700XT 
		Reference AMD RX6800
		Engineering board with Ryzen 9 5900H

		These systems were tested on the following display types: 
		eDP, (1080p 60hz [4500U, 5650U, 5900H])
		VGA and DVI (1680x1050 60HZ [DP to VGA/DVI, USB-C to DVI/VGA])
		DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz [Includes USB-C to DP/HDMI adapters])

		MST tested with Startech MST14DP123DP and 2x 4k 60Hz displays
		DSC tested with Cable Matters 101075 (DP to 3x DP), and 201375 (USB-C to 3x DP) with 3x 4k60 displays
 
		The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to):
		Changing display configurations and settings
		Benchmark testing
		Feature testing (Freesync, etc.)

		Automated testing includes (but is not limited to):
		Script testing (scripts to automate some of the manual checks)
		IGT testing

		The patchset consists of the most recent amd-staging-drm-next branch with a selection of patches added on top of it. This goes for both Ubuntu testing and Chrome 		OS testing.

		Tested on Ubuntu 22.04 and Chrome OS
 
		Tested-by: Daniel Wheeler <daniel.wheeler at amd.com>
 
 



Thank you,

Dan Wheeler
Technologist | AMD
SW Display
------------------------------------------------------------------------------------------------------------------
1 Commerce Valley Dr E, Thornhill, ON L3T 7X6
amd.com  


-----Original Message-----
From: Paul Menzel <pmenzel at molgen.mpg.de> 
Sent: May 9, 2022 10:28 AM
To: Siqueira, Rodrigo <Rodrigo.Siqueira at amd.com>
Cc: Wheeler, Daniel <Daniel.Wheeler at amd.com>; Wang, Chao-kai (Stylon) <Stylon.Wang at amd.com>; Li, Sun peng (Leo) <Sunpeng.Li at amd.com>; Wentland, Harry <Harry.Wentland at amd.com>; Zhuo, Qingqing (Lillian) <Qingqing.Zhuo at amd.com>; Li, Roman <Roman.Li at amd.com>; amd-gfx at lists.freedesktop.org; Chiu, Solomon <Solomon.Chiu at amd.com>; Pillai, Aurabindo <Aurabindo.Pillai at amd.com>; Lin, Wayne <Wayne.Lin at amd.com>; Lakha, Bhawanpreet <Bhawanpreet.Lakha at amd.com>; Gutierrez, Agustin <Agustin.Gutierrez at amd.com>; Kotarac, Pavle <Pavle.Kotarac at amd.com>
Subject: Re: How are the DC patches tested?

Dear Rodrigo,


Thank you for the quick response.

Am 09.05.22 um 16:15 schrieb Rodrigo Siqueira Jordao:

> On 2022-05-09 10:00, Paul Menzel wrote:

>> Am 09.05.22 um 15:14 schrieb Wheeler, Daniel:
>>
>> […]
>>
>>> This week this patchset was tested on the following systems:
>>>
>>> Lenovo Thinkpad T14s Gen2 with AMD Ryzen 5 5650U, with the following 
>>> display types: eDP 1080p 60hz, 4k 60hz  (via USB-C to DP/HDMI), 
>>> 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP 
>>> and then DP to DVI/VGA)
>>>
>>> Sapphire Pulse RX5700XT with the following display types: 4k 60hz 
>>> (via DP/HDMI), 1440p 144hz (via DP/HDMI), 1680*1050 60hz (via DP to
>>> DVI/VGA)
>>>
>>> Reference AMD RX6800 with the following display types: 4k 60hz  (via 
>>> DP/HDMI and USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI and 
>>> USB-C to DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA)
>>>
>>> Included testing using a Startech DP 1.4 MST hub at 2x 4k 60hz and 
>>> DSC via USB-C to DP DSC Hub with 3x 4k 60hz.
>>>
>>> Tested on Ubuntu 22.04 with Kernel Version 5.16, and ChromeOS
>>
>> I am curious, what this means exactly? You clone the Ubuntu Linux 
>> 5.16 kernel source, and then apply your patches on top? (Do they even 
>> apply?)
> 
> All of these "promotion" patches are tested by using 
> amd-staging-drm-next. In a few words:
> 
> 1. We get the latest code from amd-staging-drm-next; 2. We apply these 
> weekly promotion patches on top of it; 3. We compile, run unit tests, 
> and run many manual tests (Daniel does that).
> 
> If everything is alright with Daniel's tests, we feel confident to 
> merge these series on top amd-staging-drm-next (we are basically 
> trying to avoid regressions here).
> 
> Anyway, maybe we can rephrase:
> 
>   Tested on Ubuntu 22.04 with Kernel Version 5.16, and ChromeOS
> 
> to
> 
>   Tested on Ubuntu 22.04 and ChromeOS with amd-staging-drm-next + 
> promotion patches.

Yes, that’d be great. Maybe even reference the commit hash from the commit on top of *amd-staging-drm-next*.

(Nit: ChromeOS → Chrome OS)

>> The same for Chrome OS. Do you use Chrome OS Flex [1] with the 
>> systems you listed? If not, what Google Chromebooks/-boxes did you test with?
>> The Linux kernel version is also tied for a device and Chrome OS 
>> release. Please mention those too.

As written, the used Chrome OS version (and devices) would be helpful too.

>> Is it documented somewhere, what tests you run exactly?
> 
> We run IGT tests, some scripts that validate some specific areas, and 
> Daniel has an extensive set of manual tests.


Kind regards,

Paul