[PATCH] drm/amd: Don't reset dGPUs if the system is going to s2idle

[Alex Deucher]

On Tue, May 17, 2022 at 12:30 PM Limonciello, Mario
<Mario.Limonciello at amd.com> wrote:
>
> [Public]
>
>
>
> > PM_SUSPEND_TO_IDLE should be under a compile guard
>
>
>
> It is actually.  All of the amdgpu_acpi_* are.  It’s not obvious though looking at the patch, you need to apply it to notice it.
>
>
>
> > It makes sense to rename to something like amdgpu_need_reset_on_suspend() as it decides on reset only for a suspend situation.
>
>
>
> Remember it’s in amdgpu_acpi.c.  So it would be amdgpu_acpi_need_reset_on_suspend()?  It’s a bit lengthy.


You'll need to add a stub version of the function for the !CONFIG_ACPI
and !CONFIG_SUSPEND case since it's called in amdgpu_drv.c

Alex

>
>
>
> From: Lazar, Lijo <Lijo.Lazar at amd.com>
> Sent: Tuesday, May 17, 2022 11:25
> To: Limonciello, Mario <Mario.Limonciello at amd.com>; amd-gfx at lists.freedesktop.org
> Cc: Limonciello, Mario <Mario.Limonciello at amd.com>
> Subject: Re: [PATCH] drm/amd: Don't reset dGPUs if the system is going to s2idle
>
>
>
> [Public]
>
>
>
> A couple of things -
>
>
>
> PM_SUSPEND_TO_IDLE should be under a compile guard
>
>
>
> It makes sense to rename to something like amdgpu_need_reset_on_suspend() as it decides on reset only for a suspend situation.
>
>
>
> Thanks,
> Lijo