[PATCH] drm/amd: Don't reset dGPUs if the system is going to s2idle

[Limonciello, Mario]

[Public]

No, it mode2 reset that it uses for failure case.

From: Lazar, Lijo <Lijo.Lazar at amd.com>
Sent: Tuesday, May 17, 2022 11:51
To: Limonciello, Mario <Mario.Limonciello at amd.com>; amd-gfx at lists.freedesktop.org
Subject: Re: [PATCH] drm/amd: Don't reset dGPUs if the system is going to s2idle


[Public]

Ya, second is too lengthy.  Better to leave it as it is.

BTW, is this specific to reset by BACO? BACO entry/exit may take longer (better chance of suspend entry abort by some wake-up source).

Thanks,
Lijo
________________________________
From: Limonciello, Mario <Mario.Limonciello at amd.com<mailto:Mario.Limonciello at amd.com>>
Sent: Tuesday, May 17, 2022 10:00:16 PM
To: Lazar, Lijo <Lijo.Lazar at amd.com<mailto:Lijo.Lazar at amd.com>>; amd-gfx at lists.freedesktop.org<mailto:amd-gfx at lists.freedesktop.org> <amd-gfx at lists.freedesktop.org<mailto:amd-gfx at lists.freedesktop.org>>
Subject: RE: [PATCH] drm/amd: Don't reset dGPUs if the system is going to s2idle


[Public]



> PM_SUSPEND_TO_IDLE should be under a compile guard



It is actually.  All of the amdgpu_acpi_* are.  It's not obvious though looking at the patch, you need to apply it to notice it.



> It makes sense to rename to something like amdgpu_need_reset_on_suspend() as it decides on reset only for a suspend situation.



Remember it's in amdgpu_acpi.c.  So it would be amdgpu_acpi_need_reset_on_suspend()?  It's a bit lengthy.



From: Lazar, Lijo <Lijo.Lazar at amd.com<mailto:Lijo.Lazar at amd.com>>
Sent: Tuesday, May 17, 2022 11:25
To: Limonciello, Mario <Mario.Limonciello at amd.com<mailto:Mario.Limonciello at amd.com>>; amd-gfx at lists.freedesktop.org<mailto:amd-gfx at lists.freedesktop.org>
Cc: Limonciello, Mario <Mario.Limonciello at amd.com<mailto:Mario.Limonciello at amd.com>>
Subject: Re: [PATCH] drm/amd: Don't reset dGPUs if the system is going to s2idle



[Public]



A couple of things -



PM_SUSPEND_TO_IDLE should be under a compile guard



It makes sense to rename to something like amdgpu_need_reset_on_suspend() as it decides on reset only for a suspend situation.



Thanks,
Lijo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20220517/61548187/attachment-0001.htm>