[PATCH v1 00/13] drm/edid: expand on struct drm_edid usage
Jani Nikula
jani.nikula at intel.com
Tue May 24 10:39:22 UTC 2022
Hey all, I'm adding a bunch of people to the cover letter, sorry for the
noise.
I've been putting a lot of effort lately into cleaning up our EDID
parsing. It's been long overdue. Here, we finally leverage all that prep
work to implement the HDMI Forum HF-EEODB extension. In short, HF-EEODB
lets an EDID extension override the number of extensions indicated in
the base block. That has a lot of implications when it comes to EDID
parsing and memory allocation that is currently spread around the
subsystem.
I've added the opaque struct drm_edid in commit e4ccf9a777d3 ("drm/edid:
add struct drm_edid container"). The commit message is worth a
read. Here, I'm expanding struct drm_edid to the interfaces for EDID
reading and parsing. They all get an overhaul, along with the probe
helper .get_modes() hook.
In my mind, there is really no alternative to centralizing the EDID
parsing, and hiding the details in drm_edid.c.
I'm also adding a TODO entry; there's still a bunch of work to be done
across the subsystem.
BR,
Jani.
Cc: Adam Jackson <ajax at redhat.com>
Cc: Alex Deucher <alexander.deucher at amd.com>
Cc: Andrzej Hajda <andrzej.hajda at intel.com>
Cc: Ben Skeggs <bskeggs at redhat.com>
Cc: Christian König <christian.koenig at amd.com>
Cc: Daniel Vetter <daniel at ffwll.ch>
Cc: Dave Airlie <airlied at redhat.com>
Cc: Harry Wentland <harry.wentland at amd.com>
Cc: Karol Herbst <kherbst at redhat.com>
Cc: Laurent Pinchart <Laurent.pinchart at ideasonboard.com>
Cc: Lyude Paul <lyude at redhat.com>
Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
Cc: Maxime Ripard <mripard at kernel.org>
Cc: Neil Armstrong <narmstrong at baylibre.com>
Cc: Robert Foss <robert.foss at linaro.org>
Cc: Thomas Zimmermann <tzimmermann at suse.de>
Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
Cc: Xinhui Pan <Xinhui.Pan at amd.com>
Cc: amd-gfx at lists.freedesktop.org
Cc: nouveau at lists.freedesktop.org
Jani Nikula (13):
drm/edid: add block count and data helper functions for drm_edid
drm/edid: keep track of alloc size in drm_do_get_edid()
drm/edid: add new interfaces around struct drm_edid
drm/edid: add drm_edid_connector_update()
drm/probe-helper: abstract .get_modes() connector helper call
drm/probe-helper: make .get_modes() optional, add default action
drm/probe-helper: add .get_edid() callback
drm/edid: add drm_edid_raw() to access the raw EDID data
drm/i915/edid: convert DP, HDMI and LVDS to drm_edid
drm/edid: do invalid block filtering in-place
drm/edid: add HF-EEODB support to EDID read and allocation
drm/edid: take HF-EEODB extension count into account
drm/todo: add entry for converting the subsystem to struct drm_edid
Documentation/gpu/todo.rst | 25 +
drivers/gpu/drm/drm_connector.c | 2 +
drivers/gpu/drm/drm_edid.c | 538 ++++++++++++++++--
drivers/gpu/drm/drm_probe_helper.c | 48 +-
.../gpu/drm/i915/display/intel_connector.c | 4 +-
.../drm/i915/display/intel_display_types.h | 4 +-
drivers/gpu/drm/i915/display/intel_dp.c | 72 +--
drivers/gpu/drm/i915/display/intel_hdmi.c | 26 +-
drivers/gpu/drm/i915/display/intel_lvds.c | 35 +-
include/drm/drm_edid.h | 12 +
include/drm/drm_modeset_helper_vtables.h | 19 +
11 files changed, 650 insertions(+), 135 deletions(-)
--
2.30.2
More information about the amd-gfx
mailing list