[PATCH 2/2] drm/amdgpu: add Vangogh APU flag to IP discovery path

[Yuan, Perry]

[AMD Official Use Only - General]

Hi Alex. 

> -----Original Message-----
> From: Alex Deucher <alexdeucher at gmail.com>
> Sent: Tuesday, November 1, 2022 11:25 PM
> To: Yuan, Perry <Perry.Yuan at amd.com>
> Cc: Deucher, Alexander <Alexander.Deucher at amd.com>; Huang, Ray
> <Ray.Huang at amd.com>; Huang, Shimmer <Shimmer.Huang at amd.com>;
> amd-gfx at lists.freedesktop.org
> Subject: Re: [PATCH 2/2] drm/amdgpu: add Vangogh APU flag to IP discovery
> path
> 
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
> 
> 
> On Tue, Nov 1, 2022 at 11:19 AM Yuan, Perry <Perry.Yuan at amd.com> wrote:
> >
> > [AMD Official Use Only - General]
> >
> > Hi Alex
> >
> > > -----Original Message-----
> > > From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> On Behalf Of
> > > Alex Deucher
> > > Sent: Tuesday, November 1, 2022 9:25 PM
> > > To: Yuan, Perry <Perry.Yuan at amd.com>
> > > Cc: Deucher, Alexander <Alexander.Deucher at amd.com>; Huang, Ray
> > > <Ray.Huang at amd.com>; Huang, Shimmer <Shimmer.Huang at amd.com>;
> > > amd-gfx at lists.freedesktop.org
> > > Subject: Re: [PATCH 2/2] drm/amdgpu: add Vangogh APU flag to IP
> > > discovery path
> > >
> > > Caution: This message originated from an External Source. Use proper
> > > caution when opening attachments, clicking links, or responding.
> > >
> > >
> > > On Tue, Nov 1, 2022 at 9:23 AM Alex Deucher <alexdeucher at gmail.com>
> > > wrote:
> > > >
> > > > On Tue, Nov 1, 2022 at 1:16 AM Perry Yuan <Perry.Yuan at amd.com>
> wrote:
> > > > >
> > > > > Add the missing apu flag for Vangogh when using IP discovery
> > > > > code path to initialize IPs
> > > > >
> > > > > Signed-off-by: Perry Yuan <Perry.Yuan at amd.com>
> > > >
> > > > Swap the order of the patches.  With that, the series is:
> > > > Reviewed-by: Alex Deucher <alexander.deucher at amd.com>
> > >
> > > Actually, you also need to fix up check_seamless_boot_capability()
> > > in amdgpu_dm.c.  Switch that to an IP version check.
> > >
> > > Alex
> >
> > I am not sure if the IP versions only correctly match the GPUs.
> 
> It should match gfx IP_VERSION(10, 3, 1).  You are using that to set the APU
> flag in this patch.  The DCN version (3.0.1) is also unique to this chip and that
> would better match the fact that this is a DCN related function.
> 
> Alex

Great, this will be better to match, I will make the change in V2. 

> 
> >
> > How about using the apu flags  like this ?
> >
> > bool check_seamless_boot_capability(struct amdgpu_device *adev) {
> >         if (adev->apu_flags & AMD_APU_IS_VANGOGH) {
> >                 if (!adev->mman.keep_stolen_vga_memory)
> >                         return true;
> >         }
> >
> >         return false;
> > }
> >
> > Perry.
> >
> > >
> > >
> > > >
> > > > > ---
> > > > >  drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 1 +
> > > > >  1 file changed, 1 insertion(+)
> > > > >
> > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> > > > > b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> > > > > index 3993e6134914..52a92add12ea 100644
> > > > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> > > > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> > > > > @@ -2161,6 +2161,7 @@ int amdgpu_discovery_set_ip_blocks(struct
> > > amdgpu_device *adev)
> > > > >                 break;
> > > > >         case IP_VERSION(10, 3, 1):
> > > > >                 adev->family = AMDGPU_FAMILY_VGH;
> > > > > +               adev->apu_flags |= AMD_APU_IS_VANGOGH;
> > > > >                 break;
> > > > >         case IP_VERSION(10, 3, 3):
> > > > >                 adev->family = AMDGPU_FAMILY_YC;
> > > > > --
> > > > > 2.34.1
> > > > >