[23/33] drm/amd/display: cursor update command incomplete

[Limonciello, Mario]

On 10/20/2022 10:46, Rodrigo Siqueira wrote:
> From: Max Tseng <max.tseng at amd.com>
> 
> Missing send cursor_rect width & Height into DMUB. PSR-SU would use
> these information. But missing these assignment in last refactor commit
> 
> Reviewed-by: Anthony Koo <Anthony.Koo at amd.com>
> Acked-by: Rodrigo Siqueira <Rodrigo.Siqueira at amd.com>
> Signed-off-by: Max Tseng <max.tseng at amd.com>
> ---

This was reported to help fix a PSR-SU hang found in 6.1-rc1 and later.

Reported-by: Timur Kristóf <timur.kristof at gmail.com>
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2227
Fixes: b73353f7f3d4 ("drm/amd/display: Use the same cursor info across 
features")

Alex,

Can you please queue this for a future fixes PR for 6.1?

Thanks,

>   drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hubp.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hubp.c b/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hubp.c
> index 4996d2810edb..938dba5249d4 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hubp.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hubp.c
> @@ -623,6 +623,10 @@ void hubp2_cursor_set_attributes(
>   	hubp->att.size.bits.width    = attr->width;
>   	hubp->att.size.bits.height   = attr->height;
>   	hubp->att.cur_ctl.bits.mode  = attr->color_format;
> +
> +	hubp->cur_rect.w = attr->width;
> +	hubp->cur_rect.h = attr->height;
> +
>   	hubp->att.cur_ctl.bits.pitch = hw_pitch;
>   	hubp->att.cur_ctl.bits.line_per_chunk = lpc;
>   	hubp->att.cur_ctl.bits.cur_2x_magnify = attr->attribute_flags.bits.ENABLE_MAGNIFICATION;