[PATCH 2/2] drm/gem: Remove BUG_ON in drm_gem_private_object_init

Arunpravin Paneer Selvam arunpravin.paneerselvam at amd.com
Tue Nov 22 06:23:42 UTC 2022



On 11/22/2022 10:48 AM, Somalapuram, Amaranath wrote:
>
> On 11/16/2022 2:50 PM, Arunpravin Paneer Selvam wrote:
>> Hi Amar,
>>
>> On 11/16/2022 2:20 PM, Somalapuram Amaranath wrote:
>>> ttm_resource allocate size in bytes i.e less than page size.
>>>
>>> Signed-off-by: Somalapuram Amaranath <Amaranath.Somalapuram at amd.com>
>>> ---
>>>   drivers/gpu/drm/drm_gem.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
>>> index b8db675e7fb5..a346e3b7f9a8 100644
>>> --- a/drivers/gpu/drm/drm_gem.c
>>> +++ b/drivers/gpu/drm/drm_gem.c
>>> @@ -152,7 +152,7 @@ EXPORT_SYMBOL(drm_gem_object_init);
>>>   void drm_gem_private_object_init(struct drm_device *dev,
>>>                    struct drm_gem_object *obj, size_t size)
>>>   {
>>> -    BUG_ON((size & (PAGE_SIZE - 1)) != 0);
>>> +    //BUG_ON((size & (PAGE_SIZE - 1)) != 0);
>> This line is added by mistake?
>
> No this breaks when the size is less than page size.
>
> Now we support size in bytes.
>
I see the line BUG_ON is commented out
>>
>> Regards,
>> Arun
>>>         obj->dev = dev;
>>>       obj->filp = NULL;
>>



More information about the amd-gfx mailing list