[PATCH 3/3] drm/amdgpu: add printing to indicate rpm completeness

[Chen, Guchun]

Hi Lijo,

Thanks for your review. The cause for this change is, so far, except one line printing like "amdgpu: free PSP TMR buffer", there are no other printings once system completes rpm suspend. And moreover, "free PSP TMR buffer" sometimes confuses audiences.

Regards,
Guchun

-----Original Message-----
From: Lazar, Lijo <Lijo.Lazar at amd.com> 
Sent: Wednesday, November 23, 2022 1:58 PM
To: Chen, Guchun <Guchun.Chen at amd.com>; amd-gfx at lists.freedesktop.org; Deucher, Alexander <Alexander.Deucher at amd.com>; Zhang, Hawking <Hawking.Zhang at amd.com>; Quan, Evan <Evan.Quan at amd.com>
Subject: Re: [PATCH 3/3] drm/amdgpu: add printing to indicate rpm completeness



On 11/23/2022 7:14 AM, Guchun Chen wrote:
> Add an explicit printing to tell when finishing rpm execution in 
> amdgpu.
> 
> Signed-off-by: Guchun Chen <guchun.chen at amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c 
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> index bf2d50c8c92a..fa42c0fcf848 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> @@ -2572,6 +2572,8 @@ static int amdgpu_pmops_runtime_suspend(struct device *dev)
>   		amdgpu_device_baco_enter(drm_dev);
>   	}
>   
> +	dev_info(&pdev->dev, "amdgpu finishes runtime suspend\n");
> +

This may be an annoyance. Maybe dev_dbg?

Series is:
	Reviewed-by: Lijo Lazar <lijo.lazar at amd.com>

Thanks,
Lijo

>   	return 0;
>   }
>   
-------------- next part --------------
A non-text attachment was scrubbed...
Name: winmail.dat
Type: application/ms-tnef
Size: 14490 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20221123/df6045c4/attachment-0001.bin>