[PATCH] drm/amdkfd: Remove unnecessary condition in kfd_topology_add_device()

Felix Kuehling felix.kuehling at amd.com
Fri Nov 25 16:42:32 UTC 2022


On 2022-11-25 02:39, Dan Carpenter wrote:
> We re-arranged this code recently so "ret" is always zero at this point.
>
> Signed-off-by: Dan Carpenter <error27 at gmail.com>

Reviewed-by: Felix Kuehling <Felix.Kuehling at amd.com>

I'm applying your patch to amd-staging-drm-next. Thank you!

Felix


> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> index 6f01ebc8557b..bceb1a5b2518 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> @@ -2012,10 +2012,9 @@ int kfd_topology_add_device(struct kfd_dev *gpu)
>   
>   	kfd_debug_print_topology();
>   
> -	if (!res)
> -		kfd_notify_gpu_change(gpu_id, 1);
> +	kfd_notify_gpu_change(gpu_id, 1);
>   
> -	return res;
> +	return 0;
>   }
>   
>   /**


More information about the amd-gfx mailing list