[PATCH] drm/amdgpu: remove unnecessary condition check

Gao, Likun Likun.Gao at amd.com
Tue Oct 11 03:56:21 UTC 2022


[AMD Official Use Only - General]

Reviewed-by: Likun Gao <Likun.Gao at amd.com>.

Regards,
Likun

-----Original Message-----
From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> On Behalf Of Hawking Zhang
Sent: Tuesday, October 11, 2022 11:46 AM
To: amd-gfx at lists.freedesktop.org; Gao, Likun <Likun.Gao at amd.com>; Deucher, Alexander <Alexander.Deucher at amd.com>
Cc: Zhang, Hawking <Hawking.Zhang at amd.com>
Subject: [PATCH] drm/amdgpu: remove unnecessary condition check

version_minor>=0 is always true.

Signed-off-by: Hawking Zhang <Hawking.Zhang at amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c
index 012b72d00e04..128b65f500fe 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c
@@ -526,13 +526,12 @@ int amdgpu_gfx_rlc_init_microcode(struct amdgpu_device *adev,
        if (version_major == 2 && version_minor == 1)
                adev->gfx.rlc.is_rlc_v2_1 = true;

-       if (version_minor >= 0) {
-               err = amdgpu_gfx_rlc_init_microcode_v2_0(adev);
-               if (err) {
-                       dev_err(adev->dev, "fail to init rlc v2_0 microcode\n");
-                       return err;
-               }
+       err = amdgpu_gfx_rlc_init_microcode_v2_0(adev);
+       if (err) {
+               dev_err(adev->dev, "fail to init rlc v2_0 microcode\n");
+               return err;
        }
+
        if (version_minor >= 1)
                amdgpu_gfx_rlc_init_microcode_v2_1(adev);
        if (version_minor >= 2)
--
2.17.1



More information about the amd-gfx mailing list