[PATCH] drm/radeon: Replace kmap() with kmap_local_page()
Kees Cook
keescook at chromium.org
Fri Oct 14 02:41:39 UTC 2022
On Thu, Oct 13, 2022 at 11:07:14PM +0200, Fabio M. De Francesco wrote:
> The use of kmap() is being deprecated in favor of kmap_local_page().
>
> There are two main problems with kmap(): (1) It comes with an overhead as
> the mapping space is restricted and protected by a global lock for
> synchronization and (2) it also requires global TLB invalidation when the
> kmap’s pool wraps and it might block when the mapping space is fully
> utilized until a slot becomes available.
>
> With kmap_local_page() the mappings are per thread, CPU local, can take
> page faults, and can be called from any context (including interrupts).
> It is faster than kmap() in kernels with HIGHMEM enabled. Furthermore,
> the tasks can be preempted and, when they are scheduled to run again, the
> kernel virtual addresses are restored and still valid.
>
> Therefore, replace kmap() with kmap_local_page() in radeon_ttm_gtt_read().
>
> Cc: "Venkataramanan, Anirudh" <anirudh.venkataramanan at intel.com>
> Suggested-by: Ira Weiny <ira.weiny at intel.com>
> Signed-off-by: Fabio M. De Francesco <fmdefrancesco at gmail.com>
Reviewed-by: Kees Cook <keescook at chromium.org>
--
Kees Cook
More information about the amd-gfx
mailing list