[PATCH] drm/amdgpu: fix sdma doorbell init ordering on APUs

Shuah Khan skhan at linuxfoundation.org
Thu Oct 20 14:44:12 UTC 2022


On 10/19/22 21:48, Alex Deucher wrote:
> Commit 8795e182b02d ("PCI/portdrv: Don't disable AER reporting in get_port_device_capability()")
> uncovered a bug in amdgpu that required a reordering of the driver
> init sequence to avoid accessing a special register on the GPU
> before it was properly set up leading to an PCI AER error.  This
> reordering uncovered a different hw programming ordering dependency
> in some APUs where the SDMA doorbells need to be programmed before
> the GFX doorbells. To fix this, move the SDMA doorbell programming
> back into the soc15 common code, but use the actual doorbell range
> values directly rather than the values stored in the ring structure
> since those will not be initialized at this point.
> 
> This is a partial revert, but with the doorbell assignment
> fixed so the proper doorbell index is set before it's used.
> 
> Fixes: e3163bc8ffdfdb ("drm/amdgpu: move nbio sdma_doorbell_range() into sdma code for vega")
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
> Cc: skhan at linuxfoundation.org

Thank you for fixing this quickly and getting me back to 6.1-rc1
on my primary system.

Reported-and-Tested-by: Shuah Khan <skhan at linuxfoundation.org>

thanks,
-- Shuah




More information about the amd-gfx mailing list