[PATCH] drm/amd/display: fix memory leak when using debugfs_lookup()

Greg Kroah-Hartman gregkh at linuxfoundation.org
Tue Sep 6 15:06:45 UTC 2022


On Tue, Sep 06, 2022 at 10:52:28AM -0400, Rodrigo Siqueira Jordao wrote:
> 
> 
> On 2022-09-02 09:10, Greg Kroah-Hartman wrote:
> > On Fri, Sep 02, 2022 at 03:01:05PM +0200, Greg Kroah-Hartman wrote:
> > > When calling debugfs_lookup() the result must have dput() called on it,
> > > otherwise the memory will leak over time.  Fix this up by properly
> > > calling dput().
> > > 
> > > Cc: Harry Wentland <harry.wentland at amd.com>
> > > Cc: Leo Li <sunpeng.li at amd.com>
> > > Cc: Rodrigo Siqueira <Rodrigo.Siqueira at amd.com>
> > > Cc: Alex Deucher <alexander.deucher at amd.com>
> > > Cc: "Christian König" <christian.koenig at amd.com>
> > > Cc: "Pan, Xinhui" <Xinhui.Pan at amd.com>
> > > Cc: David Airlie <airlied at linux.ie>
> > > Cc: Daniel Vetter <daniel at ffwll.ch>
> > > Cc: Wayne Lin <Wayne.Lin at amd.com>
> > > Cc: hersen wu <hersenxs.wu at amd.com>
> > > Cc: Wenjing Liu <wenjing.liu at amd.com>
> > > Cc: Patrik Jakobsson <patrik.r.jakobsson at gmail.com>
> > > Cc: Thelford Williams <tdwilliamsiv at gmail.com>
> > > Cc: Fangzhi Zuo <Jerry.Zuo at amd.com>
> > > Cc: Yongzhi Liu <lyz_cs at pku.edu.cn>
> > > Cc: Mikita Lipski <mikita.lipski at amd.com>
> > > Cc: Jiapeng Chong <jiapeng.chong at linux.alibaba.com>
> > > Cc: Bhanuprakash Modem <bhanuprakash.modem at intel.com>
> > > Cc: Sean Paul <seanpaul at chromium.org>
> > > Cc: amd-gfx at lists.freedesktop.org
> > > Cc: dri-devel at lists.freedesktop.org
> > > Signed-off-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> > > ---
> > 
> > Despite a zillion cc: items, I forgot to cc: stable on this.  Can the
> > maintainer add that here, or do you all want me to resend it with that
> > item added?
> > 
> > thanks,
> > 
> > greg k-h
> 
> Hi Greg,
> 
> Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira at amd.com>
> 
> Is 'Cc: stable at vger.kernel.org' enough here? I can make this change before I
> merge it into amd-staging-drm-next.

Yes, please add the cc: stable@ line to the body of the patch, sorry I
forgot that.

thanks,

greg k-h


More information about the amd-gfx mailing list