[PATCH] drm/amdgpu: fix a compiling error

Christian König christian.koenig at amd.com
Mon Sep 26 09:38:41 UTC 2022


Am 26.09.22 um 11:22 schrieb Asher Song:
> The patch fix following compiling error:
>
> error: ‘for’ loop initial declarations are only allowed in C99 mode
>    for (int i = 0; i < dc->res_pool->res_cap->num_dsc; i++) {

Newer kernels are compiled in C99 mode, so this in now legal.

We should probably still fix that issue since we often port back things 
to older kernels.

>
> Signed-off-by: Asher Song <Asher.Song at amd.com>
> ---
>   drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c
> index 772ad200c5da..d58c5085600a 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c
> @@ -1405,8 +1405,8 @@ void dcn32_update_dsc_pg(struct dc *dc,
>   		bool safe_to_disable)
>   {
>   	struct dce_hwseq *hws = dc->hwseq;
> -
> -	for (int i = 0; i < dc->res_pool->res_cap->num_dsc; i++) {
> +	int i;
> +	for (i = 0; i < dc->res_pool->res_cap->num_dsc; i++) {

An empty line is required between deceleration and code. Try to use 
checkpatch.pl before sending out the patch.

Regards,
Christian.

>   		struct display_stream_compressor *dsc = dc->res_pool->dscs[i];
>   		bool is_dsc_ungated = hws->funcs.dsc_pg_status(hws, dsc->inst);
>   



More information about the amd-gfx mailing list